Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing incorrect verified notice behavior in tipping banner (0.70) #3571

Merged
merged 1 commit into from
Oct 5, 2019
Merged

Fixing incorrect verified notice behavior in tipping banner (0.70) #3571

merged 1 commit into from
Oct 5, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Oct 1, 2019

Uplift of: #3552
Fixes: brave/brave-browser#6182

@ryanml
Merge pull request #3552 from brave/fix-6182
0b8c763 
Fixing incorrect verified notice behavior in tipping banner
@ryanml ryanml added this to the 0.70.x - Beta milestone Oct 1, 2019
@ryanml ryanml requested a review from a team October 1, 2019 05:11
@ryanml ryanml requested a review from NejcZdovc as a code owner October 1, 2019 05:11
@ryanml ryanml self-assigned this Oct 1, 2019
@NejcZdovc NejcZdovc removed their request for review October 1, 2019 13:48
@kjozwiak kjozwiak mentioned this pull request Oct 1, 2019
Merged
32 tasks
kjozwiak
kjozwiak approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.70.x approved. Both CI/Jenkins and CI/Travis passed without any issues. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@ryanml ryanml merged commit b8694c0 into 0.70.x Oct 5, 2019
@ryanml ryanml deleted the uplift-3552-70 branch October 5, 2019 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@ryanml ryanml

Labels
feature/rewards
Projects
None yet
Milestone
0.70.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanml @kjozwiak