Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove patch for chrome/browser/chrome_browser_main.cc #360

Merged
merged 1 commit into from
Aug 28, 2018
Merged

remove patch for chrome/browser/chrome_browser_main.cc #360

merged 1 commit into from
Aug 28, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Aug 25, 2018

Fix brave/brave-browser#840

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bbondy bbondy self-assigned this Aug 25, 2018
@bbondy bbondy requested a review from simonhong August 25, 2018 12:01
bridiver
bridiver approved these changes Aug 27, 2018
View reviewed changes
Copy link
Collaborator

@bridiver bridiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bbondy bbondy merged commit edaf138 into master Aug 28, 2018
@bsclifton bsclifton deleted the remove-patch-1 branch September 26, 2018 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridiver bridiver bridiver approved these changes

@simonhong simonhong simonhong approved these changes

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove patch for chrome/browser/chrome_browser_main.cc
3 participants
@bbondy @bridiver @simonhong