Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix weekly stats ping (uplift to 0.71.x) #3650

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Fix weekly stats ping (uplift to 0.71.x) #3650

merged 1 commit into from
Oct 10, 2019

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Oct 10, 2019

Uplift of #3648

@emerick emerick added this to the 0.71.x - Dev milestone Oct 10, 2019
@emerick emerick self-assigned this Oct 10, 2019
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Oct 10, 2019 •
edited
Loading

@emerick I think that you are missing actual usage of this function. In master (0.72) this function was done as part of P3A (https://github.com/brave/brave-core/blob/master/browser/brave_stats_updater_params.cc#L115). But in 71 and lower GetCurrentISOWeekNumber has inlined GetIsoWeekNumber logic (https://github.com/brave/brave-core/blob/0.71.x/browser/brave_stats_updater_params.cc#L114). So probably you will need to adjust GetCurrentISOWeekNumber with calling GetIsoWeekNumber

@emerick emerick force-pushed the incorrect-weekly-pings_0.71.x branch 2 times, most recently from d1a1c6b to 942dc34 Compare October 10, 2019 11:43
@bsclifton bsclifton requested review from NejcZdovc and a team and removed request for bbondy, kjozwiak, bsclifton, rebron and srirambv October 10, 2019 16:05
bsclifton
bsclifton approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked with @NejcZdovc - this approach looks good! Discussion with approvers was 👍

@bsclifton bsclifton merged commit c332d5a into 0.71.x Oct 10, 2019
@bsclifton bsclifton deleted the incorrect-weekly-pings_0.71.x branch October 10, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@NejcZdovc NejcZdovc Awaiting requested review from NejcZdovc

Assignees

@emerick emerick

Labels
None yet
Projects
None yet
Milestone
1.0.0 - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@emerick @NejcZdovc @bsclifton