Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade patches from Chromium 77.0.3865.90 to Chromium 77.0.3865.120 #3659

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Oct 10, 2019

Fixes brave/brave-browser#6414
Related brave/brave-browser#6413


Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bsclifton bsclifton added this to the 0.69.x - next release milestone Oct 10, 2019
@bsclifton bsclifton self-assigned this Oct 10, 2019
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending CI, ++

@bsclifton
Copy link
Member Author

Tests on macOS ran into an intermittent issue:

error: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/install_name_tool: changing install names or rpaths can't be redone for: brave_browser_tests (for architecture x86_64) because larger updated load commands do not fit (the program must be relinked, and you may need to use -headerpad or -headerpad_max_install_names)

But otherwise looks good! This is something we haven't resolved yet, but typically goes away if you wipe workspace and rebuild

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants