Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow CRX3 without publisher key for websotre installs #369

Merged
merged 1 commit into from
Aug 29, 2018
Merged

Allow CRX3 without publisher key for websotre installs #369

merged 1 commit into from
Aug 29, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Aug 29, 2018 •
edited
Loading

Fix brave/brave-browser#848

Related PR and commits:
brave/brave-core-crx-packager#13

brave/vault-updater@a03de30

brave/unzip-crx@85baf0b
brave/unzip-crx@9a5497b
Which is published to npm here:
https://www.npmjs.com/package/unzip-crx-3

Unzip-crx was upstreamed in a PR here:
peerigon/unzip-crx#5

Counter issue posted here to eventually revert this:
brave/brave-browser#873

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bbondy bbondy self-assigned this Aug 29, 2018
@bbondy bbondy requested a review from simonhong August 29, 2018 06:37
@bbondy bbondy mentioned this pull request Aug 29, 2018
Merged
@bbondy bbondy requested review from petemill, bridiver and darkdh and removed request for simonhong August 29, 2018 06:45
petemill
petemill approved these changes Aug 29, 2018
View reviewed changes
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully downloaded and installed the components 👍

@bbondy bbondy merged commit 366491c into master Aug 29, 2018
darkdh
darkdh reviewed Aug 29, 2018
View reviewed changes
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton deleted the allow-crx3-without-pub-key branch September 26, 2018 05:45
@atuchin-m atuchin-m mentioned this pull request Jan 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkdh darkdh darkdh left review comments

@petemill petemill petemill approved these changes

@bridiver bridiver Awaiting requested review from bridiver

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Brave components not installing
3 participants
@bbondy @petemill @darkdh