Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade patches from Chromium 77.0.3865.90 to Chromium 78.0.3904.50 (0.70.x) #3695

Merged
merged 9 commits into from
Oct 15, 2019
Merged

Upgrade patches from Chromium 77.0.3865.90 to Chromium 78.0.3904.50 (0.70.x) #3695

merged 9 commits into from
Oct 15, 2019

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Oct 15, 2019 •
edited
Loading

Fixes brave/brave-browser#6067
Related PR brave/brave-browser#6473

Uplift request from: #3653

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

bsclifton and others added 9 commits October 14, 2019 20:42
@bsclifton @mkarolin
Merge pull request #3653 from brave/78.0.3904.50
3e8953f 
Upgrade patches from Chromium 77.0.3865.90 to Chromium 78.0.3904.50
@mkarolin
Adjusted mocked objects methods in fcm_unittest
5d3fd0f
@mkarolin
Fixes a browser test for C78.
0e541d4 
SaveCardBubbleControllerImpl::save_card_bubble_view() -> GetSaveCardBubbleView

Chromium change:

https://chromium.googlesource.com/chromium/src/+/565d2f77d08dfa1b2e8348a144c39e0412d1e502

commit 565d2f77d08dfa1b2e8348a144c39e0412d1e502
Author: siyua <siyua@chromium.org>
Date:   Wed Jul 31 18:15:35 2019 +0000

    [AF][Upstream Feedback] Stop SaveCardIconView from directly accessing
    controller Impl

    Also moved the controller interface to c/b/u/autofill/payments/

    This is a small refactoring being part of my loading bar animation CL.
    Extract it to a separate CL to unblock other CLs touching save card icon

    Bug: 964127
@bsclifton @mkarolin
Merge pull request #3667 from brave/maxk-disable-notification-triggers
f5d4b74 
Disables notification triggers API.
@AlexeyBarabash @mkarolin
Merge pull request #3681 from brave/fix_6435_sync_disable_uss
1f38317 
Disable Sync USS Bookmarks
@bsclifton @mkarolin
Merge pull request #3666 from brave/maxk-c78-l10n
e4bcd73 
Update l10n XTB and messages.json for 78.0.3904.50.
@bsclifton @mkarolin
Merge pull request #3668 from brave/fix-c78-radius
9904097 
Re-enable BraveLayoutProvider for c78
@bsclifton @mkarolin
Merge pull request #3686 from brave/maxk-fix-tor-menu
7d238ee 
Fixes Tor avatar menu after c78 bump.
@mkarolin
Lint fix.
fc8b917
@mkarolin mkarolin added this to the 0.70.x - Beta milestone Oct 15, 2019
@mkarolin mkarolin self-assigned this Oct 15, 2019
@mkarolin mkarolin mentioned this pull request Oct 15, 2019
Merged
28 tasks
@NejcZdovc NejcZdovc removed their request for review October 15, 2019 04:51
@mkarolin mkarolin changed the title WIP: Upgrade patches from Chromium 77.0.3865.90 to Chromium 78.0.3904.50 (0.70.x) Upgrade patches from Chromium 77.0.3865.90 to Chromium 78.0.3904.50 (0.70.x) Oct 15, 2019
@mkarolin
Copy link
Collaborator Author

Only CI failure is in audit deps due to remote end flakiness.

bsclifton
bsclifton approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit c4d680b into 0.70.x Oct 15, 2019
@bsclifton bsclifton deleted the 0.70.x-78.0.3904.50 branch October 15, 2019 20:59
This was referenced Oct 15, 2019
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

@iefremov iefremov Awaiting requested review from iefremov iefremov is a code owner

@tmancey tmancey Awaiting requested review from tmancey tmancey is a code owner

@NejcZdovc NejcZdovc Awaiting requested review from NejcZdovc

Assignees

@mkarolin mkarolin

Labels
None yet
Projects
None yet
Milestone
0.70.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@mkarolin @bsclifton @AlexeyBarabash