Added tests for rewards service #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonrsadler
changed the title
bridiver
reviewed
Aug 30, 2018
NejcZdovc
force-pushed
the
rewards
branch
3 times, most recently
from
c5b856e to
9e31890
Compare
|
blocked on brave/brave-ui#94 |
jasonrsadler
changed the title
|
@jasonrsadler please remove vendor files |
NejcZdovc
reviewed
Sep 3, 2018
|
vendor files removed (Thanks for the assist) |
bbondy
reviewed
Sep 3, 2018
NejcZdovc
reviewed
Sep 3, 2018
components/brave_rewards/browser/rewards_service_browsertest.cc
Outdated
Show resolved
Hide resolved
NejcZdovc
reviewed
Sep 3, 2018
components/brave_rewards/browser/rewards_service_browsertest.cc
Outdated
Show resolved
Hide resolved
NejcZdovc
approved these changes
Sep 4, 2018
11 tasks
bridiver
reviewed
Sep 5, 2018
| // toggle auto contribute off | ||
| bool result; | ||
| ASSERT_TRUE(ExecuteScriptAndExtractBool(contents(), | ||
| "var interval = setInterval(function() {" |
There was a problem hiding this comment.
this needs a max retry - see web_view_browsertest.cc WaitForWebViewInDom for an example
There was a problem hiding this comment.
@jasonrsadler can you please do a follow up for this one
This was referenced Sep 5, 2018
Merged
cezaraugusto
pushed a commit
that referenced
this pull request
Jul 17, 2019
Making Rewards panel height dynamic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#938
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Tests cover the following areas:
you can run tests with:
npm run test -- brave_browser_tests --filter=BraveRewardsBrowserTest.*Reviewer Checklist: