Rewards button icon pre-opt-in gets correct scaling

[petemill]

Sets the scale of the image compared to the size we want to display it, so that the underlying Draw function can work out if the image needs to be re-sized or not. Previously this was only happening (coincidentally) when the display was not using a scaling factor of 1 since this would not match the default scaling factor of the gfx::Image. Resize is done here: https://github.com/chromium/chromium/blob/0aa1854a269704ce0dd45641cfb9d440666e54bc/chrome/browser/ui/extensions/icon_with_badge_image_source.cc#L147-L148

Fix: brave/brave-browser#6663

This should be uplifted to wherever #3698 is uplifted to (currently 0.71.x).

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Android
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that these changes pass automated tests (unit, browser, security tests) on
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protection-Mode
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

On brave/brave-browser#6663

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[petemill]

@mkarolin thanks for spotting the lack of includes. Have amended here https://github.com/brave/brave-core/compare/0fbbb9dfef5be5195aaec209a3c37a2e7b5ad602..e3f343af79a871990abba6cedc2d818a2392be66

[mkarolin]

++

[simonhong]

This works on Windows debug build 👍

[simonhong]

I'm not sure this is related with this PR but crash happened when I click rewards button.
I can see this crash only on linux.
=> I can see this crash w/o this PR. Maybe another change caused this crash.

Received signal 11 SEGV_MAPERR 000000000000
#0 0x7f0f0bead72f base::debug::CollectStackTrace()
#1 0x7f0f0bbe4d1d base::debug::StackTrace::StackTrace()
#2 0x7f0f0bbe4cd8 base::debug::StackTrace::StackTrace()
#3 0x7f0f0bead1de base::debug::(anonymous namespace)::StackDumpSignalHandler()
#4 0x7f0ed5908890 <unknown>
#5 0x55f762ff8e78 ExtensionActionViewController::ExecuteAction()
#6 0x55f762ff8dcd ExtensionActionViewController::ExecuteAction()
#7 0x55f75e000b67 BraveActionsContainer::AddAction()
#8 0x55f75e001adb BraveActionsContainer::OnExtensionLoaded()
#9 0x55f75ce3158c extensions::ExtensionRegistry::TriggerOnLoaded()
#10 0x55f75ce2a3ea extensions::ExtensionRegistrar::ActivateExtension()
#11 0x55f75ce2a2c3 extensions::ExtensionRegistrar::AddNewExtension()
#12 0x55f75ce2937c extensions::ExtensionRegistrar::AddExtension()
#13 0x55f7617ca2bd extensions::ExtensionService::AddExtension()
#14 0x55f7617ca7c9 extensions::ExtensionService::AddComponentExtension()
#15 0x55f75e68e6b7 extensions::BraveExtensionService::AddComponentExtension()
#16 0x55f76173a75c extensions::ComponentLoader::Load()
#17 0x55f76173ad76 extensions::ComponentLoader::Add()
#18 0x55f76173abd2 extensions::ComponentLoader::Add()
#19 0x55f76173aaf8 extensions::ComponentLoader::Add()
#20 0x55f75e68a69a extensions::BraveComponentLoader::AddRewardsExtension()
#21 0x55f75e001a6a BraveActionsContainer::OnRewardsStubButtonClicked()
#22 0x55f75e014377 BraveRewardsActionStubView::ButtonPressed()
#23 0x7f0ef576da9b views::Button::NotifyClick()
#24 0x7f0ef576b89c views::Button::DefaultButtonControllerDelegate::NotifyClick()
#25 0x7f0ef5772027 views::ButtonController::OnMouseReleased()
#26 0x7f0ef576ca9f views::Button::OnMouseReleased()
#27 0x7f0ef58e58b4 views::View::ProcessMouseReleased()
#28 0x7f0ef58e53b9 views::View::OnMouseEvent()
#29 0x7f0efa9e330b ui::EventHandler::OnEvent()
#30 0x7f0efa9f593c ui::ScopedTargetHandler::OnEvent()
#31 0x7f0efa9e0284 ui::EventDispatcher::DispatchEvent()
#32 0x7f0efa9dfbdb ui::EventDispatcher::ProcessEvent()
#33 0x7f0efa9df83c ui::EventDispatcherDelegate::DispatchEventToTarget()
#34 0x7f0efa9df665 ui::EventDispatcherDelegate::DispatchEvent()
#35 0x7f0ef5905f29 views::internal::RootView::OnMouseReleased()
#36 0x7f0ef590f21d views::Widget::OnMouseEvent()
#37 0x7f0ef5964e81 views::DesktopNativeWidgetAura::OnMouseEvent()
#38 0x7f0efa9e330b ui::EventHandler::OnEvent()
#39 0x7f0efa9e0284 ui::EventDispatcher::DispatchEvent()
#40 0x7f0efa9dfbdb ui::EventDispatcher::ProcessEvent()
#41 0x7f0efa9df83c ui::EventDispatcherDelegate::DispatchEventToTarget()
#42 0x7f0efa9df665 ui::EventDispatcherDelegate::DispatchEvent()
#43 0x7f0efa9e4a60 ui::EventProcessor::OnEventFromSource()
#44 0x7f0efa9e4d04 ui::EventProcessor::OnEventFromSource()
#45 0x7f0efa9e6923 ui::EventSource::DeliverEventToSink()
#46 0x7f0efa9e66a8 ui::EventSource::SendEventToSinkFromRewriter()
#47 0x7f0efa9e63e1 ui::EventSource::SendEventToSink()
#48 0x7f0ef597c4c0 views::DesktopWindowTreeHostX11::DispatchMouseEvent()
#49 0x7f0ef597cd03 views::DesktopWindowTreeHostX11::DispatchEvent()

[simonhong]

Confirmed on linux (ubuntu) and Win10 that rewards icon is displayed with proper scaling.
I can see crash on linux when rewards button is clicked, but it seems another issue.

[petemill]

Thanks @simonhong , I'll check out the crash

[petemill]

FYI @simonhong 's crash was caused by setting the "Extensions Toolbar Menu" flag to true. That is a known issue and the flag is disabled by default.