Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport importer bugfixes #3837

Merged
merged 2 commits into from
Nov 13, 2019
Merged

Backport importer bugfixes #3837

merged 2 commits into from
Nov 13, 2019

Conversation

iefremov
Copy link
Contributor

@iefremov iefremov commented Oct 31, 2019

Fixes brave/brave-browser#6521

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@iefremov iefremov self-assigned this Oct 31, 2019
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix worked great for me! 😄

Will have to defer to @bridiver on the patching- this is a special case, since it's pulling in fixes that are in Canary but aren't in Stable yet... not sure how we want to handle that.

I've verified this is resolved in Chromium 80 (tested with Dev and Canary channels; and since 79 on Beta isn't finalized, they may uplift it). If we wanted to avoid patching master, we could PR specifically against 0.71 (C78), 0.72 (C79), and 0.73 (C79)

@bridiver WDYT?

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@iefremov iefremov merged commit f69be6c into master Nov 13, 2019
@iefremov iefremov deleted the ie_firefox_import branch November 13, 2019 21:53
@bbondy
Copy link
Member

bbondy commented Nov 15, 2019

Can we uplift this pls? Also pls set the milestone on the issue to match the smallest version it landed on. Thank you! :)

@bsclifton bsclifton added this to the 1.3.x - Nightly milestone Nov 19, 2019
brave-builds pushed a commit that referenced this pull request Nov 19, 2019
brave-builds pushed a commit that referenced this pull request Nov 19, 2019
@LaurenWags
Copy link
Member

Verified with

Brave 1.3.17 Chromium: 78.0.3904.108 (Official Build) nightly (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS macOS Version 10.13.6 (Build 17G5019)
  • Using the following Firefox version

Screen Shot 2019-11-20 at 10 27 34 AM

  • Confirmed FF displayed on brave://welcome as an option for Import.

Screen Shot 2019-11-20 at 10 19 44 AM

  • Confirmed FF displayed on brave://settings/importData as an option for Import.

Screen Shot 2019-11-20 at 10 25 19 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firefox no longer appearing in list of browsers to import from
5 participants