-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport importer bugfixes #3837
Conversation
0033bf1
to
d804c06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix worked great for me! 😄
Will have to defer to @bridiver on the patching- this is a special case, since it's pulling in fixes that are in Canary but aren't in Stable yet... not sure how we want to handle that.
I've verified this is resolved in Chromium 80 (tested with Dev
and Canary
channels; and since 79 on Beta
isn't finalized, they may uplift it). If we wanted to avoid patching master, we could PR specifically against 0.71 (C78), 0.72 (C79), and 0.73 (C79)
@bridiver WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Can we uplift this pls? Also pls set the milestone on the issue to match the smallest version it landed on. Thank you! :) |
Verified with
|
Fixes brave/brave-browser#6521
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.