Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing handlebars vulnerability #3878

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Fixing handlebars vulnerability #3878

merged 1 commit into from
Nov 4, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Nov 4, 2019

Fixes: brave/brave-browser#6763

Submitter Checklist:

Test Plan:

Verify by running npm run test-security

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added the security label Nov 4, 2019
@ryanml ryanml added this to the 0.73.x - Nightly milestone Nov 4, 2019
@ryanml ryanml requested a review from bsclifton November 4, 2019 20:47
@ryanml ryanml self-assigned this Nov 4, 2019
@bsclifton bsclifton changed the title Fixing handelbars vulnerability Fixing handlebars vulnerability Nov 4, 2019
@ryanml ryanml removed the security label Nov 4, 2019
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit f360454 into master Nov 4, 2019
@bsclifton bsclifton deleted the dep-fix branch November 4, 2019 21:48
bsclifton added a commit that referenced this pull request Nov 4, 2019
Fixing handlebars vulnerability
bsclifton added a commit that referenced this pull request Nov 4, 2019
@bsclifton
Copy link
Member

0.72.x 6454dc5
0.71.x 20dca88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handelbars dependency vulnerability
2 participants