Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix localization of "Close" command in Russian in tab context menu. #3951

Merged
merged 1 commit into from
Nov 9, 2019

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Nov 9, 2019

Fixes brave/brave-browser#6767

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added the CI/skip Do not run CI builds (except noplatform) label Nov 9, 2019
@mkarolin mkarolin added this to the 0.71.x - Release milestone Nov 9, 2019
@mkarolin mkarolin requested a review from bsclifton November 9, 2019 00:46
@mkarolin mkarolin self-assigned this Nov 9, 2019
@mkarolin mkarolin changed the title Localization fix. Fix localization of "Close" command in Russian in tab context menu. Nov 9, 2019
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 44d4ee6 into 0.71.x Nov 9, 2019
@bsclifton bsclifton deleted the maxk-fix-localization branch November 9, 2019 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants