Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing wallet summary flex basis #3987

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Fixing wallet summary flex basis #3987

merged 1 commit into from
Nov 13, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Nov 13, 2019

Fixes brave/brave-browser#6684

Screen Shot 2019-11-13 at 11 48 38 AM

Screen Shot 2019-11-13 at 11 50 40 AM

With recent text updates we no longer needed the change to flex basis that was introduced during initial BAP points update

Submitter Checklist:

Test Plan:

Defined in issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 1.3.x - Nightly milestone Nov 13, 2019
@ryanml ryanml requested a review from a team November 13, 2019 18:52
@ryanml ryanml self-assigned this Nov 13, 2019
@ryanml ryanml merged commit b3611b0 into master Nov 13, 2019
@ryanml ryanml deleted the fix-6684 branch November 13, 2019 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alignment issue for Token grants claimed in BR panel
2 participants