Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds check for public key when getting tokens #4008

Merged
merged 3 commits into from
Nov 27, 2019
Merged

Adds check for public key when getting tokens #4008

merged 3 commits into from
Nov 27, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Nov 18, 2019

Resolves brave/brave-browser#6939

Submitter Checklist:

Test Plan:

  • enable rewards
  • claim grant
  • make sure that balance updates correctly

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc self-assigned this Nov 18, 2019
@NejcZdovc NejcZdovc marked this pull request as ready for review November 18, 2019 11:07
@NejcZdovc
Copy link
Contributor Author

waiting for grant-virtualization to be merged and @evq to change logic on server side

@NejcZdovc NejcZdovc changed the base branch from grant-virtualization to master November 19, 2019 17:16
@NejcZdovc NejcZdovc merged commit 61367b2 into master Nov 27, 2019
@NejcZdovc NejcZdovc deleted the public-key branch November 27, 2019 14:32
hashmi-waseem pushed a commit to hashmi-waseem/brave-core that referenced this pull request May 6, 2024
Fix the Ad Rewards settings panel 0.63.x
hashmi-waseem pushed a commit to hashmi-waseem/brave-core that referenced this pull request May 6, 2024
Fix the Ad Rewards settings panel 0.64.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check public key
2 participants