Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update release description text #402

Merged
merged 1 commit into from
Sep 5, 2018
Merged

update release description text #402

merged 1 commit into from
Sep 5, 2018

Conversation

mihaiplesa
Copy link
Collaborator

@mihaiplesa mihaiplesa commented Sep 5, 2018 •
edited
Loading

updates release description text in upload.py

fixes brave/brave-browser#954

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@mihaiplesa mihaiplesa requested a review from mbacchi September 5, 2018 18:51
mbacchi
mbacchi approved these changes Sep 5, 2018
View reviewed changes
Copy link
Contributor

@mbacchi mbacchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@mihaiplesa mihaiplesa changed the title fixes issue #954 update release description text Sep 5, 2018
@mihaiplesa mihaiplesa merged commit b2b8da7 into master Sep 5, 2018
@mihaiplesa mihaiplesa deleted the update-release-description-text branch September 5, 2018 19:22
@bbondy
Copy link
Member

bbondy commented Sep 8, 2018

Merge was missing label, added 0.55.x label
Issue associated was missing assigned milestone, added Releasable builds so the message would be updated in our CI builds.

0.55.x c4d5195

@bbondy bbondy added the 0.55.x label Sep 8, 2018
@mihaiplesa
Copy link
Collaborator Author

My apologies for this, will make sure to get it right next time.

@bbondy
Copy link
Member

bbondy commented Sep 8, 2018

np at all, thanks!

@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbacchi mbacchi mbacchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.55.x - Release
Development

Successfully merging this pull request may close these issues.

Update release description text in upload.py
3 participants
@mihaiplesa @bbondy @mbacchi