Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 78.0.3904.108 to Chromium 79.0.3945.45 #4043

Closed
wants to merge 69 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
69 commits
Select commit Hold shift + click to select a range
5de8158
Upgrade patches from Chromium 78.0.3904.108 to Chromium 79.0.3945.45.
mkarolin Oct 23, 2019
b35e780
ntp_tiles_strings.grdp has been removed.
mkarolin Oct 24, 2019
6ba5550
Added missing headers.
mkarolin Oct 24, 2019
51d4e12
Updated chrome_constants.cc override.
mkarolin Oct 24, 2019
748996c
Updated url_constants.cc override.
mkarolin Oct 25, 2019
642e807
PostTaskWithTraits -> PostTask
mkarolin Oct 24, 2019
6652e75
syncer::Cryptographer became abstract.
mkarolin Oct 24, 2019
e547542
Use HighlightPathGenerator.
mkarolin Oct 24, 2019
935a416
Use different AssociatedInterfaceProvider::GetInterfaces.
mkarolin Oct 24, 2019
706c0a9
LookUpProxyForURL now takes PendingRemote.
mkarolin Oct 25, 2019
32c5342
Socket::AcceptCompletionCallback now takes PendingRemote.
mkarolin Oct 25, 2019
46f4900
CreatePrefService now thakes PendingRemote.
mkarolin Oct 25, 2019
5867151
AlertIndicator::alert_state_ is now base::Optional.
mkarolin Oct 25, 2019
cee47cc
Profile menu's SetIdentityInfo signature change.
mkarolin Oct 25, 2019
103e9d9
NewExtensionUpdaterService is not feature gated.
mkarolin Oct 25, 2019
a69f4b3
HandleExternalProtocol now takes initiating_origin
pilgrim-brave Oct 25, 2019
3550c26
LOCATION_BAR_BUBBLE_CORNER_RADIUS was removed.
mkarolin Oct 25, 2019
0892bfd
webrtc_ip_handling_policy.h moved to blink.
mkarolin Oct 25, 2019
4140111
Don't std::move temporary objects
pilgrim-brave Oct 25, 2019
730dcb8
LaunchUrl now takes initiating_origin
pilgrim-brave Oct 25, 2019
f6ee60f
Profile attributes SetName -> SetLocalProfileName.
mkarolin Oct 25, 2019
e2bab46
URLLoaderFactory now takes PendingReceiver
pilgrim-brave Oct 25, 2019
0406b6a
ProxyWebSocket::OnConnectionEstablished now takes WebSocketHandshakeR…
pilgrim-brave Oct 25, 2019
b878406
ProxyingWebSocket::OnHeadersReceived now takes remote_endpoint
pilgrim-brave Oct 25, 2019
0b73dae
ProxyingWebSocket::OnResponseReceived no longer exists
pilgrim-brave Oct 25, 2019
bc8364c
Moved overriding omnibox colors to theme service.
mkarolin Oct 25, 2019
821ee3d
Avatar button changes.
mkarolin Oct 26, 2019
0a80d99
ProfileAttributesStorage::AddProfile signature change.
mkarolin Oct 26, 2019
7b8fa80
ExternalProcessImportBridge now uses mojom observer.
mkarolin Oct 28, 2019
4abe884
PageActionIcon interface changes.
mkarolin Oct 28, 2019
cc0053f
ProfileManager::CreateProfileHelper now returns unique_ptr.
mkarolin Oct 28, 2019
cbc88a3
TestBrowserThreadBundle was removed.
mkarolin Oct 28, 2019
b41be7a
GetAvatarToolbarButton is now in ToolbarButtonProvider.
mkarolin Oct 28, 2019
db6911a
Removed MD_ prefix from overriden extension strings.
mkarolin Oct 29, 2019
23072fc
Added missing compress=gzip to webui resource.
mkarolin Oct 29, 2019
3448a50
Reworked ChromeTypographyProvider override.
mkarolin Oct 30, 2019
8c0febb
Fixes Avatar menu for c79.
mkarolin Oct 29, 2019
0bf517b
Fixes location bar focus ring shape.
mkarolin Oct 30, 2019
533467a
permission service is now accessed through BrowserInterfaceBroker
pilgrim-brave Oct 31, 2019
5a31d3b
Workaround for build error on Linux.
mkarolin Nov 1, 2019
a85461d
Linux: add GetDesktopName to override of channel_info_posix.cc
mkarolin Nov 1, 2019
0c450d4
IsDefauleProfileName takes an additional param now.
mkarolin Nov 8, 2019
22331ce
Stop relying on set_sources_assignment_filter.
mkarolin Nov 8, 2019
d65856d
refactor SecurityIndicatorTest.CheckIndicatorText to use testing params
pilgrim-brave Oct 31, 2019
e791d32
Disable widevine cdm component in linux
simonhong Nov 25, 2019
845825a
Fixes Widevine on Linux.
mkarolin Nov 1, 2019
d5cd7c8
Fix DCHECK failure when restaring browser after install Widevine
simonhong Nov 25, 2019
bfd0d51
Delete deprecated widevine cdm lib file
simonhong Nov 25, 2019
7c901ad
[Android] Changes in CrashpadClient API signatures.
mkarolin Nov 15, 2019
4c14ea7
[Android] SigninManagfer API signatures changes.
mkarolin Nov 15, 2019
cb75e4f
[Android] RoundedIconGenerator moved.
mkarolin Nov 15, 2019
a2f3914
[Android] showAccessibilityToast() moved to Toast.showAnchoredToast()
mkarolin Nov 15, 2019
055eb72
[Android] AppMenuPropertiesDelegateImpl API signature change.
mkarolin Nov 15, 2019
31d1aee
[Android] getUserBadgedDrawableForDensity signature change.
mkarolin Nov 15, 2019
52546a4
Fixes a label in Clear Browsing Data dialog.
mkarolin Nov 19, 2019
2bdafec
[Android 64] Fixes build error due to CanonicalCookie::Create API cha…
mkarolin Nov 20, 2019
024602c
[Android 64] Fixes build error with cdm::AddAndroidWidevine.
mkarolin Nov 21, 2019
68dcc15
[Android] Fixes bottom toolbar.
mkarolin Nov 22, 2019
74eac4c
Fixes an assertion in transifext script.
mkarolin Nov 21, 2019
c0f5ace
Updated transifex script to fetch iw Hebrew XTBs.
mkarolin Nov 22, 2019
e34568a
[iOS] Workaround for compilation error.
mkarolin Nov 22, 2019
90fdb9d
[Android] Fixes BraveThemePreferences.
mkarolin Nov 23, 2019
048c27a
Lint fixes.
mkarolin Nov 22, 2019
ed0274a
Code Review Fixes.
mkarolin Nov 25, 2019
a7608f0
Added missing header.
mkarolin Nov 25, 2019
4545e2d
Additional changes for WebSocket Proxy.
mkarolin Nov 26, 2019
3c22488
Fixes crash in BraveLocationBarView.
mkarolin Nov 26, 2019
da8a6a4
Update strings for 79.0.3945.45
mkarolin Nov 20, 2019
9695737
Update l10n XTB and messages.json for 79.0.3945.45
mkarolin Nov 22, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
import org.chromium.chrome.browser.favicon.LargeIconBridge;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tabmodel.TabModelImpl;
import org.chromium.chrome.browser.widget.RoundedIconGenerator;
import org.chromium.chrome.browser.ui.widget.RoundedIconGenerator;
import org.chromium.chrome.R;


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
import android.graphics.Bitmap;
import android.widget.ImageView;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.widget.RoundedIconGenerator;
import org.chromium.chrome.browser.ui.widget.RoundedIconGenerator;
import org.chromium.base.task.AsyncTask;
import android.graphics.BitmapFactory;
import org.chromium.base.annotations.CalledByNative;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import org.chromium.base.ObservableSupplier;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ActivityTabProvider;
import org.chromium.chrome.browser.bookmarks.BookmarkBridge;
import org.chromium.chrome.browser.compositor.layouts.OverviewModeBehavior;
import org.chromium.chrome.browser.multiwindow.MultiWindowModeStateDispatcher;
import org.chromium.chrome.browser.notifications.BraveSetDefaultBrowserNotificationService;
Expand All @@ -24,12 +25,14 @@
public class BraveAppMenuPropertiesDelegateImpl extends AppMenuPropertiesDelegateImpl {
private Menu mMenu;

public BraveAppMenuPropertiesDelegateImpl(Context context, ActivityTabProvider activityTabProvider,
public BraveAppMenuPropertiesDelegateImpl(Context context,
ActivityTabProvider activityTabProvider,
MultiWindowModeStateDispatcher multiWindowModeStateDispatcher,
TabModelSelector tabModelSelector, ToolbarManager toolbarManager, View decorView,
@Nullable ObservableSupplier<OverviewModeBehavior> overviewModeBehaviorSupplier) {
@Nullable ObservableSupplier<OverviewModeBehavior> overviewModeBehaviorSupplier,
ObservableSupplier<BookmarkBridge> bookmarkBridgeSupplier) {
super(context, activityTabProvider, multiWindowModeStateDispatcher, tabModelSelector,
toolbarManager, decorView, overviewModeBehaviorSupplier);
toolbarManager, decorView, overviewModeBehaviorSupplier, bookmarkBridgeSupplier);
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,15 @@

package org.chromium.chrome.browser.preferences.themes;

import static org.chromium.chrome.browser.preferences.ChromePreferenceManager.DARKEN_WEBSITES_ENABLED_KEY;
import static org.chromium.chrome.browser.preferences.ChromePreferenceManager.UI_THEME_SETTING_KEY;

import android.os.Bundle;
import android.support.annotation.Nullable;

import org.chromium.chrome.R;
import org.chromium.base.BuildInfo;
import org.chromium.chrome.browser.ChromeFeatureList;
import org.chromium.chrome.browser.night_mode.GlobalNightModeStateProviderHolder;
import org.chromium.chrome.browser.preferences.ChromePreferenceManager;
import org.chromium.chrome.browser.preferences.PreferenceUtils;
Expand All @@ -22,6 +24,7 @@ public void onCreatePreferences(@Nullable Bundle savedInstanceState, String root
PreferenceUtils.addPreferencesFromResource(this, R.xml.brave_theme_preferences);
getActivity().setTitle(getResources().getString(R.string.prefs_themes));

ChromePreferenceManager chromePreferenceManager = ChromePreferenceManager.getInstance();
BraveRadioButtonGroupThemePreference radioButtonGroupThemePreference =
(BraveRadioButtonGroupThemePreference) findPreference(PREF_UI_THEME_PREF);

Expand All @@ -31,12 +34,18 @@ public void onCreatePreferences(@Nullable Bundle savedInstanceState, String root
? ThemeSetting.DARK
: ThemeSetting.LIGHT;
}
radioButtonGroupThemePreference.initialize(ChromePreferenceManager.getInstance().readInt(
UI_THEME_SETTING_KEY, defaultThemePref));
radioButtonGroupThemePreference.initialize(
chromePreferenceManager.readInt(UI_THEME_SETTING_KEY, defaultThemePref),
chromePreferenceManager.readBoolean(DARKEN_WEBSITES_ENABLED_KEY, false));

radioButtonGroupThemePreference.setOnPreferenceChangeListener((preference, newValue) -> {
if (ChromeFeatureList.isEnabled(
ChromeFeatureList.DARKEN_WEBSITES_CHECKBOX_IN_THEMES_SETTING)) {
chromePreferenceManager.writeBoolean(DARKEN_WEBSITES_ENABLED_KEY,
radioButtonGroupThemePreference.isDarkenWebsitesEnabled());
}
int theme = (int) newValue;
ChromePreferenceManager.getInstance().writeInt(UI_THEME_SETTING_KEY, theme);
chromePreferenceManager.writeInt(UI_THEME_SETTING_KEY, theme);
return true;
});
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,14 @@
import org.chromium.base.ContextUtils;
import org.chromium.base.annotations.CalledByNative;
import org.chromium.components.signin.AccountTrackerService;
import org.chromium.components.signin.identitymanager.IdentityManager;
import org.chromium.components.signin.identitymanager.IdentityMutator;
import org.chromium.components.sync.AndroidSyncSettings;

public class BraveSigninManager extends SigninManager {
BraveSigninManager(Context context, long nativeSigninManagerAndroid,
AccountTrackerService accountTrackerService) {
super(context, nativeSigninManagerAndroid, accountTrackerService,
BraveSigninManager(long nativeSigninManagerAndroid, AccountTrackerService accountTrackerService,
IdentityManager identityManager, IdentityMutator identityMutator) {
super(nativeSigninManagerAndroid, accountTrackerService, identityManager, identityMutator,
AndroidSyncSettings.get());
}

Expand All @@ -30,11 +32,14 @@ public boolean isSigninSupported() {
}

@CalledByNative
private static SigninManager create(
long nativeSigninManagerAndroid, AccountTrackerService accountTrackerService) {
private static SigninManager create(long nativeSigninManagerAndroid,
AccountTrackerService accountTrackerService, IdentityManager identityManager,
IdentityMutator identityMutator) {
assert nativeSigninManagerAndroid != 0;
assert accountTrackerService != null;
return new BraveSigninManager(ContextUtils.getApplicationContext(),
nativeSigninManagerAndroid, accountTrackerService);
assert identityManager != null;
assert identityMutator != null;
return new BraveSigninManager(nativeSigninManagerAndroid, accountTrackerService,
identityManager, identityMutator);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@
import org.chromium.chrome.browser.tabmodel.TabModelSelectorTabObserver;
import org.chromium.chrome.browser.tabmodel.TabSelectionType;
import org.chromium.chrome.browser.toolbar.top.ToolbarLayout;
import org.chromium.chrome.browser.util.AccessibilityUtil;
import org.chromium.chrome.browser.util.ColorUtils;
import org.chromium.chrome.browser.util.MathUtils;
import org.chromium.chrome.browser.util.PackageUtils;
import org.chromium.ui.interpolators.BakedBezierInterpolator;
import org.chromium.ui.widget.Toast;

import java.net.URL;
import java.util.List;
Expand Down Expand Up @@ -266,7 +266,7 @@ public boolean onLongClick(View v) {
description = resources.getString(R.string.accessibility_toolbar_btn_brave_rewards);
}*/

return AccessibilityUtil.showAccessibilityToast(context, v, description);
return Toast.showAnchoredToast(context, v, description);
}

public void populateUrlAnimatorSet(boolean hasFocus, int urlFocusToolbarButtonsDuration,
Expand Down
Loading