-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Tab Page Branded Wallpapers (desktop) #4075
Commits on Jan 24, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 2d693a8 - Browse repository at this point
Copy the full SHA 2d693a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f3ca18 - Browse repository at this point
Copy the full SHA 2f3ca18View commit details -
New Tab Page WebUI: grid is more modular, allows items to collapse an…
…d branded credit to extend upwards in to free space in another row
Configuration menu - View commit details
-
Copy full SHA for 528ef67 - Browse repository at this point
Copy the full SHA 528ef67View commit details -
New Tab Page: Backend and API for Branded Wallpaper, including correc…
…t view counts and demo content
Configuration menu - View commit details
-
Copy full SHA for 0de449e - Browse repository at this point
Copy the full SHA 0de449eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e6b4265 - Browse repository at this point
Copy the full SHA e6b4265View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22bc549 - Browse repository at this point
Copy the full SHA 22bc549View commit details -
Configuration menu - View commit details
-
Copy full SHA for 473ac52 - Browse repository at this point
Copy the full SHA 473ac52View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b1d676 - Browse repository at this point
Copy the full SHA 9b1d676View commit details -
New Tab Page WebUI: Widget menu becomes optional
Branded Wallpaper Logo wants to use common widget styling but not have a menu. Functionality to turn that off is contained within the New Tab Page settings.
Configuration menu - View commit details
-
Copy full SHA for 4471768 - Browse repository at this point
Copy the full SHA 4471768View commit details -
Configuration menu - View commit details
-
Copy full SHA for d408bb2 - Browse repository at this point
Copy the full SHA d408bb2View commit details -
New Tab Page WebUI: Show external link indicator on Branded Wallpaper…
… logo interaction
Configuration menu - View commit details
-
Copy full SHA for f289bc1 - Browse repository at this point
Copy the full SHA f289bc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7376699 - Browse repository at this point
Copy the full SHA 7376699View commit details -
New Tab Page: Put branded wallpaper features behind two brave://flags:
1. Enable branded wallpapers 2. Force dummy content for Branded Wallpaper
Configuration menu - View commit details
-
Copy full SHA for 3442c4f - Browse repository at this point
Copy the full SHA 3442c4fView commit details -
New Tab Page: Support multiple branded wallpaper images
Images are displayed in sequence in the order specified in the data
Configuration menu - View commit details
-
Copy full SHA for e5bf80a - Browse repository at this point
Copy the full SHA e5bf80aView commit details -
Implement backend service for ntp sponsored images
NTPSponsoredImagesService registers proper components based on locale and will notify to its observers whenever components is updated. NTPSponsoredImageSource serves branded images.
Configuration menu - View commit details
-
Copy full SHA for f4c8432 - Browse repository at this point
Copy the full SHA f4c8432View commit details -
Rename NTPSponsoredImagesService to NTPSponsoredImagesComponentManager
Renamed because NTPSponsoredImagesService manages component registration and component update. and Service is normaly used by KeyedService. Also, Client should do some jobs per profile. It's adding and updating URLDataSources per profile whenever component is updated. NTPSponsoredImagesService(BrowserContextKeyedService) will be added for that job.
Configuration menu - View commit details
-
Copy full SHA for 436f74f - Browse repository at this point
Copy the full SHA 436f74fView commit details
Commits on Jan 25, 2020
-
Implement NTPSponsoredImagesService
This service will add/update proper URLDataSource for serving branded images to webui.
Configuration menu - View commit details
-
Copy full SHA for 580ea35 - Browse repository at this point
Copy the full SHA 580ea35View commit details -
Implement NTPSponsoredImageSource::StartDataRequest()
With this, chrome://branded-logo.png and chrome://branded-wallpaper-N.jpg are loaded. And separate ImagesData into exported data and internal data. exported data doesn't need to have file path for image resources.
Configuration menu - View commit details
-
Copy full SHA for 9c1d5ff - Browse repository at this point
Copy the full SHA 9c1d5ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for b522095 - Browse repository at this point
Copy the full SHA b522095View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5d3ed6 - Browse repository at this point
Copy the full SHA a5d3ed6View commit details -
Update method definition of overloaded operator=
Normally, overloaded assign operator returns references of its object. Of course, using wrong return type doesn't have any differences because we deleted this.
Configuration menu - View commit details
-
Copy full SHA for 5cac240 - Browse repository at this point
Copy the full SHA 5cac240View commit details -
Use one URLDataSource for branded-wallpaper host
Use brave://branded-wallpaper/logo.png or brave://branded-wallpaper/wallpaper-N.jpg
Configuration menu - View commit details
-
Copy full SHA for 41d7574 - Browse repository at this point
Copy the full SHA 41d7574View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46be4d4 - Browse repository at this point
Copy the full SHA 46be4d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4024f49 - Browse repository at this point
Copy the full SHA 4024f49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3029302 - Browse repository at this point
Copy the full SHA 3029302View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b05c41 - Browse repository at this point
Copy the full SHA 5b05c41View commit details -
Don't build ntp_sponsored_images as a component
Some of modules in this deps list doesn't build as a component. Because of this, they could be included in many places in component build.
Configuration menu - View commit details
-
Copy full SHA for f2b3da8 - Browse repository at this point
Copy the full SHA f2b3da8View commit details -
Configuration menu - View commit details
-
Copy full SHA for f50183c - Browse repository at this point
Copy the full SHA f50183cView commit details -
WebUI string helper to extract components of translated strings desti…
…ned for HTML elements, such as links or bold text
Configuration menu - View commit details
-
Copy full SHA for d244e46 - Browse repository at this point
Copy the full SHA d244e46View commit details -
New Tab Page WebUI: Allow Widgets to have widget functionality disabl…
…ed. Useful for notifications.
Configuration menu - View commit details
-
Copy full SHA for c7c2b2b - Browse repository at this point
Copy the full SHA c7c2b2bView commit details
Commits on Jan 26, 2020
-
New Tab Page WebUI: Rewards widget re-design and more Branded Wallpap…
…er notification states
Configuration menu - View commit details
-
Copy full SHA for 81c21ba - Browse repository at this point
Copy the full SHA 81c21baView commit details -
Provide default move constructor to NTPSponsoredImagesData
This move ctor needs for implicit converting to Optional().
Configuration menu - View commit details
-
Copy full SHA for 63c654b - Browse repository at this point
Copy the full SHA 63c654bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 64b2359 - Browse repository at this point
Copy the full SHA 64b2359View commit details -
Relaxed no_deps rules of ntp_sponsored_images target
brave_ads component has //chrome/android dependency. So changed no_deps rule from //chrome/* to //chrome/browser/*.
Configuration menu - View commit details
-
Copy full SHA for 25a3313 - Browse repository at this point
Copy the full SHA 25a3313View commit details -
Disable no_deps in ntp_sponsored_images target
brave_ads components eventually has //chrome/browser dependency. So, temporarilly disable no_deps.
Configuration menu - View commit details
-
Copy full SHA for 689cbc3 - Browse repository at this point
Copy the full SHA 689cbc3View commit details -
New Tab Page WebUI: Fix rewards widget thinks ads are off when reward…
…s are re-enabled Fix brave/brave-browser#7807
Configuration menu - View commit details
-
Copy full SHA for a6c6dab - Browse repository at this point
Copy the full SHA a6c6dabView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f49c34 - Browse repository at this point
Copy the full SHA 6f49c34View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ad6513 - Browse repository at this point
Copy the full SHA 5ad6513View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1722d9 - Browse repository at this point
Copy the full SHA c1722d9View commit details -
New Tab Page WebUI: All widget scenarios allow for branded logo to si…
…t next to any gaps in the left column
Configuration menu - View commit details
-
Copy full SHA for d3730f9 - Browse repository at this point
Copy the full SHA d3730f9View commit details -
New Tab Page: Branded wallpaper notification show and dismiss logic b…
…ased on a profile preference which is reset when Rewards or Ads is toggled on or off
Configuration menu - View commit details
-
Copy full SHA for 4c10929 - Browse repository at this point
Copy the full SHA 4c10929View commit details -
New Tab Page: Start NewTabPageBrandedViewCounter at profile init so t…
…hat it can keep track of rewards and ads toggles in order to reset notification dismiss flag
Configuration menu - View commit details
-
Copy full SHA for 4479a41 - Browse repository at this point
Copy the full SHA 4479a41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9607758 - Browse repository at this point
Copy the full SHA 9607758View commit details -
Deprecate BrandedWallpaper data structure
Instead use NTPSponsoredImagesData
Configuration menu - View commit details
-
Copy full SHA for 7292ef2 - Browse repository at this point
Copy the full SHA 7292ef2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e8c044 - Browse repository at this point
Copy the full SHA 5e8c044View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0f9f88 - Browse repository at this point
Copy the full SHA c0f9f88View commit details -
Correct current_wallpaper_image_index_ calculation
So far, image index was 1 -> 2 -> 0 -> 1 -> 2 -> 0 with 3 images. It should be 0 -> 1 -> 2 -> 0 -> 1 -> 2 -> 0
Configuration menu - View commit details
-
Copy full SHA for 36fd337 - Browse repository at this point
Copy the full SHA 36fd337View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fea909 - Browse repository at this point
Copy the full SHA 9fea909View commit details -
Configuration menu - View commit details
-
Copy full SHA for 789fccd - Browse repository at this point
Copy the full SHA 789fccdView commit details -
Launch NewTabPageBrandedViewCounter only when it is needed
We don't need to initiate NewTabPageBrandedViewCounter when branded ntp feature is disabled.
Configuration menu - View commit details
-
Copy full SHA for 42d6865 - Browse repository at this point
Copy the full SHA 42d6865View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ba3931 - Browse repository at this point
Copy the full SHA 4ba3931View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ed5bf0 - Browse repository at this point
Copy the full SHA 9ed5bf0View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc02497 - Browse repository at this point
Copy the full SHA bc02497View commit details -
Make NewTabPageBrandedViewCounter add URLDataSource
NTPSponsoredImagesService was used only for adding URLDataSource. and we have another service for ntp sponsorship. So, unified to ViewCounter service.
Configuration menu - View commit details
-
Copy full SHA for 9dd4b60 - Browse repository at this point
Copy the full SHA 9dd4b60View commit details -
Configuration menu - View commit details
-
Copy full SHA for aeab4ad - Browse repository at this point
Copy the full SHA aeab4adView commit details -
Rename NTPSponsoredImagesComponentManager
To NTPSponsoredImagesService because it doesn't manage component. And fixed lint errors and added missing deps.
Configuration menu - View commit details
-
Copy full SHA for bc8dda3 - Browse repository at this point
Copy the full SHA bc8dda3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cad9f5 - Browse repository at this point
Copy the full SHA 5cad9f5View commit details
Commits on Jan 27, 2020
-
refactor to remove brave/browser and chrome/browser dependencies outs…
…ide of ViewCounterServiceFactory
Configuration menu - View commit details
-
Copy full SHA for 278fb27 - Browse repository at this point
Copy the full SHA 278fb27View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d86102 - Browse repository at this point
Copy the full SHA 2d86102View commit details