Fixes mac notarization that C79 update broke. #4122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes brave/brave-browser#7191 When creating config use ChromiumCodeSigningConfig instead of the now bare bones model.CodeSignConfig. Chromium change: https://chromium.googlesource.com/chromium/src/+/c04be46a5d8ecbc2cf4d565a453d11212a9fd124 commit c04be46a5d8ecbc2cf4d565a453d11212a9fd124 Author: Robert Sesek <rsesek@chromium.org> Date: Wed Sep 18 00:57:47 2019 +0000 macOS Signing Scripts: Split the config class and expand the hierarchy. The base CodeSignConfig is now in a normal Python module and it has unimplemented properties. The build-system-injected variables inherit from that for the BuildPropsCodeSignConfig. A new ChromiumCodeSignConfig class is created to set the signing properties for Chromium, to mirror the InternalCodeSignConfig for Google Chrome builds. Both ChromiumConfig and InternalCodeSignConfig inherit from the BuildPropsCodeSignConfig. This makes it easier to use the signing module without needing to process a config file.
mkarolin
added
CI/skip-android
mkarolin
added
CI/skip
mkarolin
added a commit
that referenced
this pull request
Dec 4, 2019
Fixes mac notarization that C79 update broke.
mkarolin
added a commit
that referenced
this pull request
Dec 4, 2019
Fixes mac notarization that C79 update broke.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#7191
When creating config use ChromiumCodeSigningConfig instead of the now
bare bones model.CodeSignConfig.
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.