Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes brave://version Brave logo in dark mode. (uplift to 1.1.x) #4158

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Fixes brave://version Brave logo in dark mode. (uplift to 1.1.x) #4158

merged 1 commit into from
Dec 6, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Dec 6, 2019 •
edited by bsclifton
Loading

Uplift of #4149
Fixes brave/brave-browser#7221

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Dec 6, 2019
@brave-builds brave-builds added this to the 1.1.x - Release milestone Dec 6, 2019
@bsclifton bsclifton requested review from a team and removed request for bbondy, kjozwiak, bsclifton, rebron and srirambv December 6, 2019 06:02
kjozwiak
kjozwiak approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.1.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any issues. Please make sure that correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit e6c9545 into 1.1.x Dec 6, 2019
@kjozwiak kjozwiak deleted the pr4149_maxk-fix-version-logo_1.1.x branch December 6, 2019 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.1.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases