Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds up to to AC settings page #4179

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Adds up to to AC settings page #4179

merged 1 commit into from
Dec 9, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Dec 9, 2019

Resolves brave/brave-browser#7277

Submitter Checklist:

Test Plan:

  • enable rewards
  • go to settings page
  • open AC settings
  • make sure that you see up to for monthly amount

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc requested a review from a team December 9, 2019 12:52
@NejcZdovc NejcZdovc self-assigned this Dec 9, 2019
@NejcZdovc NejcZdovc added this to the 1.4.x - Nightly milestone Dec 9, 2019
@NejcZdovc NejcZdovc added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS labels Dec 9, 2019
Copy link
Contributor

@masparrow masparrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would add a note to the Test plan to 'Check both AC panel and AC Settings drop down'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add up to to AC settings
2 participants