Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sec Issue Fix (1.2.x) #4196

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Sec Issue Fix (1.2.x) #4196

merged 1 commit into from
Dec 11, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Dec 10, 2019

Uplift of: #4186
Fixes: brave/brave-browser#7291

@ryanml ryanml added this to the 1.2.x - Beta milestone Dec 10, 2019
@ryanml ryanml requested a review from a team December 10, 2019 05:22
@ryanml ryanml self-assigned this Dec 10, 2019
@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Dec 11, 2019
@kjozwiak
Copy link
Member

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.2.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any errors after a few restarts. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit c82ee68 into 1.2.x Dec 11, 2019
@kjozwiak kjozwiak deleted the uplift-7291-1.2.x branch December 11, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants