Use the correct name for the setuid sandbox (uplift to 1.2.x) #4260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brave-builds
requested review from
bbondy,
bsclifton,
kjozwiak,
rebron and
srirambv
|
Restarting Restarting |
kjozwiak
approved these changes
Dec 24, 2019
There was a problem hiding this comment.
Uplift into 1.2.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins & CI/Travis passed without any issues after restarting. I went through #4223 (comment) and ensured the PR was working as expected. @fmarier also went through the PR on Nightly.
Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.
kjozwiak
deleted the
pr4223_francois-rename-chrome-sandbox-6247_1.2.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift of #4223
Approved, please ensure that before merging:
After you merge: