Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes unable to get ad tokens if tokens are not ready - 1.4.x #4336

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jan 8, 2020

@tmancey tmancey added this to the 1.4.x - Dev milestone Jan 8, 2020
@tmancey tmancey requested a review from a team January 8, 2020 23:48
@tmancey tmancey self-assigned this Jan 8, 2020
@tmancey tmancey changed the title Fixes unable to get ad tokens if tokens are not ready Fixes unable to get ad tokens if tokens are not ready - 1.4.x Jan 9, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Jan 9, 2020

Restarting Linux due to https://ci.brave.com/job/brave-browser-build-pr/job/issues%252F7666-1.4.x/1/execution/node/502/log/ failing. This is a known intermittent issue that's not related to this specific PR. However, because macOS is being restarted, I'll just restart Linux as well.

Restarting macOS due to https://ci.brave.com/job/brave-browser-build-pr/job/issues%252F7666-1.4.x/1/execution/node/706/log/ failing.

Restarting https://travis-ci.org/brave/brave-core/jobs/634490808 a it also failed.

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-windows and removed PR/Pending Review labels Jan 9, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Jan 9, 2020

@tmancey once we a have Nightly that's >=1.5.23, can you double check and make sure the original PR is working as expected? Once that's completed, can you also add the below checklist into #4336 (comment).

Approved, please ensure that before merging: 
- [ ] You have checked CI and the builds, lint, and tests all pass or are not related to your PR. 
- [ ] You have tested your change on Nightly. 
- [ ] The PR milestones match the branch they are landing to. 

After you merge: 
- [ ] The associated issue milestone is set to the smallest version that the changes is landed on.

QA will also go through the original PR on Nightly to make sure things are working as expected. If everything looks good on our side, we'll start the uplift process.

@tmancey
Copy link
Collaborator Author

tmancey commented Jan 14, 2020

@kjozwiak

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.4.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any issues after several restarts. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 2ba5ad8 into 1.4.x Jan 14, 2020
@kjozwiak kjozwiak deleted the issues/7666-1.4.x branch January 14, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants