Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-generate NTP backgrounds LICENSE file #4481

Merged
merged 2 commits into from
Feb 18, 2020

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Feb 3, 2020

Fixes brave/brave-browser#7460 along with brave/brave-browser#8032.

This doesn't change the licensing info, it simply moves everything into the same metadata file.

Submitter Checklist:

Test Plan:

npm run build Release

Look at the "Background images" entry in brave://credits. It should contain URLs and licenses for all 16 background images.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@fmarier fmarier self-assigned this Feb 3, 2020
@fmarier fmarier force-pushed the generate-backgrounds-license-file-7460 branch from 51774bc to 84072d7 Compare February 12, 2020 01:31
@fmarier fmarier force-pushed the generate-backgrounds-license-file-7460 branch 3 times, most recently from 7afb736 to 639bb12 Compare February 12, 2020 22:12
@fmarier fmarier requested a review from petemill February 12, 2020 22:13
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ Do we need to add a comment to say don't change the data structure without changing the license generator script?

@petemill
Copy link
Member

or I guess that an error would be thrown by brave-browser

@fmarier
Copy link
Member Author

fmarier commented Feb 12, 2020

or I guess that an error would be thrown by brave-browser

Yeah if the licensing info can't be found, the licensing script will kick up a fuss and break the build.

@fmarier fmarier force-pushed the generate-backgrounds-license-file-7460 branch from 639bb12 to 61efa9e Compare February 15, 2020 01:26
These mandatory reviews are no longer necessary since the LICENSE
file is now automatically generated and missing licensing info
will cause a build failure.
@fmarier fmarier force-pushed the generate-backgrounds-license-file-7460 branch from 61efa9e to fd9c185 Compare February 17, 2020 21:35
@fmarier fmarier merged commit e037050 into master Feb 18, 2020
@fmarier fmarier deleted the generate-backgrounds-license-file-7460 branch February 18, 2020 02:27
@bbondy bbondy added this to the 1.7.x - Release milestone Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically generate brave-core/components/brave_new_tab_ui/data/LICENSE
4 participants