-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide sync option in settings if it's disabled #4572
Conversation
ac61e43
to
7bad3da
Compare
7bad3da
to
b2ef143
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM (pending addressing feedback by @darkdh)
For others reading this, user would need to enable flag via brave://flags
That would set the isSyncEnabled
to true. I verified this works great locally 😄 👍
b2ef143
to
8e5cfb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Got unrelated build error on Win64.
Started to rebuild only on Win64. |
CI success on all platform. |
Verified using
Verified STR from brave/brave-browser#8159 |
fix brave/brave-browser#8159
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
See brave/brave-browser#8159
Reviewer Checklist:
After-merge Checklist:
changes has landed on.