Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterate the UI light theme #477

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Iterate the UI light theme #477

merged 1 commit into from
Sep 19, 2018

Conversation

petemill
Copy link
Member

@petemill petemill commented Sep 19, 2018

Fix brave/brave-browser#961

Hardcoded colors for now, will follow-up with variables for the palette and re-using from Omnibox to ThemeProperties when we validate these values with the designers in the build.

image

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

Fix brave/brave-browser#961

Hardcoded colors for now, will follow-up with variables for the palette and re-using from Omnibox to ThemeProperties when we validate these values with the designers in the build.
@petemill petemill added the UI label Sep 19, 2018
@petemill petemill self-assigned this Sep 19, 2018
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Q: deleting all of our location bar border color is intentional?

@petemill
Copy link
Member Author

@simonhong looks to me like the refresh UI doesn't use the LocationBar border property from ThemeProperties, since the border is set to 0. The only situation there is a border is for the focus ring, which is controlled by #476.

Thanks for the speedy review!

@petemill petemill merged commit fe95af6 into master Sep 19, 2018
petemill added a commit that referenced this pull request Sep 19, 2018
@petemill
Copy link
Member Author

0.55.x 91aa0cc

@petemill petemill deleted the ui/light-theme branch September 19, 2018 04:58
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Light theme color refinement
3 participants