Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import from Chrome #49

Merged
merged 6 commits into from
Mar 15, 2018
Merged

Import from Chrome #49

merged 6 commits into from
Mar 15, 2018

Commits on Mar 14, 2018

  1. Import bookmarks and history from Chrome, with some minor issues

    Garrett Robinson committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    c39c897 View commit details
    Browse the repository at this point in the history

  2. Fix favicon import from Chrome

    Garrett Robinson committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    ef3594c View commit details
    Browse the repository at this point in the history

  3. Fix bookmark import from Chrome 

    - Fix incorrect propagation of is_in_toolbar flag
- Only add ImportedBookmarkEntry for folders if they're empty

Importing bookmarks from Chrome now conforms to the behavior described
in the comment for ProfileWriter::AddBookmarks:
https://cs.chromium.org/chromium/src/chrome/browser/importer/profile_writer.h?l=56-73&rcl=219101ecc0143651567d49340e80fb5b3e756b40
    Garrett Robinson committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    5c68c87 View commit details
    Browse the repository at this point in the history

  4. Tests for importing History, Bookmarks, and Favicons from Chrome

    Garrett Robinson committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    20ca9be View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2018

  1. Use MPL

    Garrett Robinson committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    5b11755 View commit details
    Browse the repository at this point in the history

  2. Support importing from Chrome Canary and Chromium too

    Garrett Robinson committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    9a4a3db View commit details
    Browse the repository at this point in the history