Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix https://stats.brave.com/dashboard#crash/5ba4dfdff772c9001e621e5e #490

Merged
merged 1 commit into from
Sep 24, 2018
Merged

fix https://stats.brave.com/dashboard#crash/5ba4dfdff772c9001e621e5e #490

merged 1 commit into from
Sep 24, 2018

Conversation

bridiver
Copy link
Collaborator

Still need to add a new test case to cover the crash report

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bridiver bridiver self-assigned this Sep 22, 2018
bbondy
bbondy approved these changes Sep 24, 2018
View reviewed changes
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and merging for now but if you can come up with a test case that would be appreciated.

@bbondy bbondy merged commit 7236dd8 into master Sep 24, 2018
bbondy added a commit that referenced this pull request Sep 24, 2018
@bbondy
Merge pull request #490 from brave/insecure_referrer
e8b5aba 
fix https://stats.brave.com/dashboard#crash/5ba4dfdff772c9001e621e5e
@bsclifton bsclifton deleted the insecure_referrer branch September 26, 2018 05:43
@bbondy
Copy link
Member

bbondy commented Sep 26, 2018

0.55.x e8b5aba
master 7236dd8

@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
petemill pushed a commit to petemill/brave-core that referenced this pull request Jul 3, 2019
@cezaraugusto @petemill
Undo revert of brave/brave-ui#485
0e4145a 
Revert "Merge pull request brave#490 from brave/revert-485"

This reverts commit 82b3e981040b2ba89743108e6701f5fa24ce3b52, reversing
changes made to b0ec08cd4ed2a20401d058062f1c238fb9a67813.
petemill pushed a commit to petemill/brave-core that referenced this pull request Jul 5, 2019
@NejcZdovc
Imported from brave-ui: Merge pull request brave#490 from brave/rever…
391a65c 
…t-485

Revert "Merge pull request brave#485 from brave/toggle-background-img"
petemill pushed a commit to petemill/brave-core that referenced this pull request Jul 5, 2019
@cezaraugusto @imptrx
Imported from brave-ui: Undo revert of brave/brave-ui#485
f02ce47 
Revert "Merge pull request brave#490 from brave/revert-485"

This reverts commit 82b3e981040b2ba89743108e6701f5fa24ce3b52, reversing
changes made to b0ec08cd4ed2a20401d058062f1c238fb9a67813.
petemill pushed a commit that referenced this pull request Jul 5, 2019
@cezaraugusto @petemill
Imported from brave-ui: Undo revert of brave/brave-ui#485
a97cf11 
Revert "Merge pull request #490 from brave/revert-485"

This reverts commit 82b3e981040b2ba89743108e6701f5fa24ce3b52, reversing
changes made to b0ec08cd4ed2a20401d058062f1c238fb9a67813.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

@yrliou yrliou Awaiting requested review from yrliou

Assignees

@bridiver bridiver

Labels
None yet
Projects
None yet
Milestone
0.55.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@bridiver @bbondy