Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields: Better accomodate long strings in non-English languages #4954

Closed
wants to merge 1 commit into from

Conversation

cezaraugusto
Copy link
Contributor

Reviewer's note: PR #4946 is needed for this.

Close brave/brave-browser#4575

Submitter Checklist:

Test Plan:

  1. Run Brave
  2. Switch language to Russian
  3. Should match screenshot attached

Lazy way:

  1. npm run storybook
  2. Go to localeAPI.ts file and change message path from en_US to ru
  3. Should match screenshot attached

Screen Shot 2020-03-16 at 12 35 49 PM

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@cezaraugusto cezaraugusto added feature/shields CI/skip Do not run CI builds (except noplatform) labels Mar 16, 2020
@cezaraugusto cezaraugusto self-assigned this Mar 16, 2020
@cezaraugusto
Copy link
Contributor Author

Cleaning up my assignments, closing this as stale.

@bsclifton bsclifton deleted the ca-4575 branch November 10, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform) feature/shields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant