Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from Chromium 80.0.3987.132 to Chromium 80.0.3987.149 (1.5.x). #4982

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Mar 18, 2020

Fixes brave/brave-browser#8728
Related PR: brave/brave-browser#8745

Uplift from: #4974

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Update from Chromium 80.0.3987.132 to Chromium 80.0.3987.149.
@kjozwiak
Copy link
Member

Travis is failing TEST_SUITE=test-security due to the minimist npm package being vulnerable. It's a known issue as per brave/brave-browser#8722 and doesn't block the PR from being uplifted.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.5.x approved after deliberating with @brave/uplift-approvers. As per #4982 (comment), the Travis failures are known and not specific to this PR. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 5a51ae2 into 1.5.x Mar 18, 2020
@kjozwiak kjozwiak deleted the 80.0.3987.149-1.5.x branch March 18, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants