Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up patches with asm #5127

Merged
merged 2 commits into from
Apr 1, 2020
Merged

clean up patches with asm #5127

merged 2 commits into from
Apr 1, 2020

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Apr 1, 2020

Resolves brave/brave-browser#8966

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bridiver bridiver added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Apr 1, 2020
@bridiver bridiver requested a review from SergeyZhukovsky April 1, 2020 01:40
@bridiver bridiver self-assigned this Apr 1, 2020
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@SergeyZhukovsky SergeyZhukovsky added this to the 1.8.x - Nightly milestone Apr 1, 2020
@bridiver bridiver merged commit 0491f20 into master Apr 1, 2020
@bridiver bridiver deleted the disable_android_permissions_2 branch April 1, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] add additional asm options to reduce patches
2 participants