Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DEPS to include new brave-extension #525

Merged
merged 1 commit into from
Sep 28, 2018

Conversation

bsclifton
Copy link
Member

after brave/brave-extension#67 was merged

That commit adds "incognito": "split" to the extension manifest (matching browser-laptop behavior)

Helps with addressing brave/brave-browser#1198

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bsclifton bsclifton merged commit 78c5c7d into master Sep 28, 2018
@bsclifton bsclifton deleted the bsc-update-extension-manifest branch September 28, 2018 21:39
bsclifton added a commit that referenced this pull request Sep 28, 2018
Update DEPS to include new brave-extension
bsclifton added a commit that referenced this pull request Sep 28, 2018
Update DEPS to include new brave-extension
@bsclifton
Copy link
Member Author

master 78c5c7d
0.56.x 64e0be2
0.55.x 65c323f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants