Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnects the Binance widget upon hiding #5265

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Disconnects the Binance widget upon hiding #5265

merged 1 commit into from
Apr 16, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Apr 15, 2020

Fixes: brave/brave-browser#9244

Submitter Checklist:

Test Plan:

Defined in issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 1.9.x - Nightly milestone Apr 15, 2020
@ryanml ryanml requested a review from bbondy April 15, 2020 21:52
@ryanml ryanml self-assigned this Apr 15, 2020
@@ -219,6 +219,13 @@ class NewTabPage extends React.Component<Props, State> {
}

this.props.saveShowBinance(!showBinance)

// If we are about to hide the widget, disconnect
if (showBinance) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewer: This doesn't need to be !showBinance as this value represents the current state of the visibility, this is a toggle function that passes in the opposite.

@ryanml
Copy link
Contributor Author

ryanml commented Apr 16, 2020

Jenkins CI passed, Travis failure unrelated

@ryanml ryanml merged commit 574b538 into master Apr 16, 2020
@ryanml ryanml deleted the fix-9244 branch April 16, 2020 03:04
bsclifton pushed a commit that referenced this pull request Apr 21, 2020
Disconnects the Binance widget upon hiding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binance Widget should be disconnected after hiding
2 participants