Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix brave/extensions/renderer build error #528

Merged
merged 1 commit into from
Sep 30, 2018
Merged

Fix brave/extensions/renderer build error #528

merged 1 commit into from
Sep 30, 2018

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Sep 29, 2018 •
edited
Loading

Add proper dependency list.

Close brave/brave-browser#1352

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Check gn path out/Debug //brave/extensions/renderer //extensions/buildflags

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@simonhong
Fix brave/extensions/renderer build error
2ab4d0d 
Add proper dependency list.
@simonhong simonhong self-assigned this Sep 29, 2018
AlexeyBarabash
AlexeyBarabash approved these changes Sep 29, 2018
View reviewed changes
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@jasonrsadler jasonrsadler merged commit 5e17638 into master Sep 30, 2018
jasonrsadler pushed a commit that referenced this pull request Sep 30, 2018
Merge pull request #528 from brave/fix_brave_extension_renderer_build…
8fc3ccb 
…_error

Fix brave/extensions/renderer build error
jasonrsadler pushed a commit that referenced this pull request Sep 30, 2018
Merge pull request #528 from brave/fix_brave_extension_renderer_build…
a8e0b32 
…_error

Fix brave/extensions/renderer build error
@jasonrsadler
Copy link
Contributor

master: 5e17638
0.55.x: 8fc3ccb
0.56.x: a8e0b32

@simonhong simonhong deleted the fix_brave_extension_renderer_build_error branch October 4, 2018 13:39
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
fmarier pushed a commit that referenced this pull request Oct 29, 2019
@mbacchi
Merge pull request #528 from brave/bump_version
6e1f0ed 
Bump version (v0.50.9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexeyBarabash AlexeyBarabash AlexeyBarabash approved these changes

@bbondy bbondy Awaiting requested review from bbondy

Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
0.55.x - Release
Development

Successfully merging this pull request may close these issues.

Build fails on Linux Debug, 'extensions/buildflags/buildflags.h' file not found
4 participants
@simonhong @jasonrsadler @AlexeyBarabash @bbondy