Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persists selected view in the Binance Widget #5285

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Persists selected view in the Binance Widget #5285

merged 1 commit into from
Apr 20, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Apr 18, 2020

Fixes brave/brave-browser#9257

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 1.9.x - Nightly milestone Apr 18, 2020
@ryanml ryanml requested a review from bbondy April 18, 2020 01:37
@ryanml ryanml self-assigned this Apr 18, 2020
@ryanml
Copy link
Contributor Author

ryanml commented Apr 20, 2020

All steps passed, CI failure due to:

17:16:13  [  FAILED  ] BraveRewardsBrowserTest.NotVerifiedWallet, where TypeParam =  and GetParam() =  (6109 ms)
17:16:13  [539/539] BraveRewardsBrowserTest.NotVerifiedWallet (6338 ms)
17:16:13  1 test failed:
17:16:13      BraveRewardsBrowserTest.NotVerifiedWallet (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2326)
17:16:13  null

@ryanml ryanml merged commit d7761ca into master Apr 20, 2020
@ryanml ryanml deleted the fix-9257 branch April 20, 2020 17:14
bsclifton pushed a commit that referenced this pull request Apr 21, 2020
Persists selected view in the Binance Widget
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reload newtab page reset widget to default summary view
2 participants