Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses noopener for Binance URLs, client url validation #5286

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Apr 18, 2020

Fixes brave/brave-browser#9317

Submitter Checklist:

Test Plan:

Defined in issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 1.9.x - Nightly milestone Apr 18, 2020
@ryanml ryanml requested review from diracdeltas and bbondy April 18, 2020 21:48
@ryanml ryanml self-assigned this Apr 18, 2020
Copy link
Member

@diracdeltas diracdeltas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryanml
Copy link
Contributor Author

ryanml commented Apr 20, 2020

CI unrelated

@ryanml ryanml merged commit 8a0594e into master Apr 20, 2020
@ryanml ryanml deleted the fix-9317 branch April 20, 2020 02:04
bsclifton pushed a commit that referenced this pull request Apr 21, 2020
Uses noopener for Binance URLs, client url validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

noopener should be in use for opening Binance auth and referral URLs
2 participants