Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed accidentally committed debug code. #5371

Merged
merged 1 commit into from
Apr 25, 2020
Merged

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#9462

Accidental commit in PR #5350

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added the CI/skip Do not run CI builds (except noplatform) label Apr 25, 2020
@mkarolin mkarolin added this to the 1.10.x - Nightly milestone Apr 25, 2020
@mkarolin mkarolin self-assigned this Apr 25, 2020
@mkarolin mkarolin requested a review from bsclifton April 25, 2020 05:36
@ryanml ryanml self-requested a review April 25, 2020 20:49
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw the error this morning, thanks for fixing!

@mkarolin mkarolin assigned ryanml and unassigned ryanml Apr 25, 2020
@mkarolin mkarolin merged commit de1da7e into master Apr 25, 2020
@mkarolin mkarolin deleted the maxk-fix-transifex branch April 25, 2020 21:26
@mkarolin
Copy link
Collaborator Author

Thanks for the approval @ryanml

mkarolin added a commit that referenced this pull request Apr 25, 2020
Removed accidentally committed debug code.
mkarolin added a commit that referenced this pull request Apr 25, 2020
Removed accidentally committed debug code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove accidentally committed code in Transifex script.
2 participants