Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix buffer overflow in AudioBuffer::copyFromChannel (uplift to 1.8.x) #5432

Merged
merged 1 commit into from
May 2, 2020
Merged

Fix buffer overflow in AudioBuffer::copyFromChannel (uplift to 1.8.x) #5432

merged 1 commit into from
May 2, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Apr 30, 2020 •
edited by kjozwiak
Loading

Uplift of #5427
Fixes brave/brave-browser#9552

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Apr 30, 2020
@brave-builds brave-builds added this to the 1.8.x - Placeholder milestone Apr 30, 2020
@bsclifton bsclifton requested review from a team and removed request for bridiver, bbondy, kjozwiak, bsclifton, rebron and srirambv April 30, 2020 20:55
@kjozwiak
Copy link
Member

kjozwiak commented May 1, 2020

Restarting as the b-b job never started and timed out.

@bsclifton
Copy link
Member

CI timed out on init for Windows; other platforms all passed 😄
https://ci.brave.com/job/brave-browser-build-pr/job/pr5427_mpilgrim_fix_audio_buffer_1.8.x/1/flowGraphTable/

Gonna mark with appropriate skip labels and restart

@bsclifton bsclifton added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels May 1, 2020
kjozwiak
kjozwiak approved these changes May 2, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.9.x approved after deliberating with @brave/uplift-approvers. QA verified the PR on Nightly as per #5427 (comment). Ensured that all the needed labels are being used and issue is moved into the associated milestone.

@kjozwiak kjozwiak merged commit fb9ae76 into 1.8.x May 2, 2020
@kjozwiak kjozwiak deleted the pr5427_mpilgrim_fix_audio_buffer_1.8.x branch May 2, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.8.x - Release Hotfix 1
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @bsclifton @brave-browser-releases