Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrates stack widget state to list format #5445

Merged
merged 1 commit into from
May 5, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented May 2, 2020

Fixes brave/brave-browser#9584

Submitter Checklist:

Test Plan:

Defined in issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanml ryanml force-pushed the widget-stack-data-migration branch from b5edba6 to 8b88508 Compare May 4, 2020 15:56
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@ryanml
Copy link
Contributor Author

ryanml commented May 5, 2020

Builds generated, CI failures unrelated

@ryanml ryanml merged commit e1dd7e9 into master May 5, 2020
@ryanml ryanml deleted the widget-stack-data-migration branch May 5, 2020 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move widget stack state to list format
3 participants