Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WebRTC IP leak in Tor profile #545

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Fix WebRTC IP leak in Tor profile #545

merged 1 commit into from
Oct 2, 2018

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Oct 2, 2018 •
edited by darkdh
Loading

Fix brave/brave-browser#1254

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

npm run test -- brave_unit_tests --filter=BraveProfileManagerTest.*
Open https://browserleaks.com/webrtc in Tor window, no IP addresses should be shown.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@yrliou yrliou self-assigned this Oct 2, 2018
@yrliou yrliou requested review from bbondy and darkdh October 2, 2018 03:42
@yrliou yrliou merged commit 51fe496 into master Oct 2, 2018
yrliou added a commit that referenced this pull request Oct 2, 2018
@yrliou
Merge pull request #545 from brave/fix_tor_webrtc_ip_leak
d80738e 
Fix WebRTC IP leak in Tor profile
yrliou added a commit that referenced this pull request Oct 2, 2018
@yrliou
Merge pull request #545 from brave/fix_tor_webrtc_ip_leak
4752bf1 
Fix WebRTC IP leak in Tor profile
@yrliou
Copy link
Member Author

yrliou commented Oct 2, 2018

master: 51fe496
0.55.x: d80738e
0.56.x: 4752bf1

@yrliou yrliou deleted the fix_tor_webrtc_ip_leak branch October 2, 2018 18:10
@LaurenWags LaurenWags mentioned this pull request Oct 8, 2018
Closed
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
fmarier pushed a commit that referenced this pull request Oct 29, 2019
@cezaraugusto
Merge pull request #545 from NejcZdovc/ts
be15b73 
Adds TypeScript support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkdh darkdh darkdh approved these changes

@bbondy bbondy Awaiting requested review from bbondy

Assignees

@yrliou yrliou

Labels
None yet
Projects
None yet
Milestone
0.55.x - Release
Development

Successfully merging this pull request may close these issues.

Always block WebRTC in Tor
3 participants
@yrliou @darkdh @bbondy