Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS signing on master #5469

Merged
merged 1 commit into from
May 6, 2020
Merged

Fix macOS signing on master #5469

merged 1 commit into from
May 6, 2020

Conversation

bsclifton
Copy link
Member

Remove unused libspeedreader.dylib reference

Not needed after #5142

Fixes brave/brave-browser#9650

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bsclifton bsclifton added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-ios Do not run CI builds for iOS labels May 6, 2020
@bsclifton bsclifton added this to the 1.10.x - Nightly milestone May 6, 2020
@bsclifton bsclifton self-assigned this May 6, 2020
@bsclifton
Copy link
Member Author

Build in progress on macOS only which will do signing:
https://ci.brave.com/job/pr-brave-browser-bsc-fix-macos-signing/3/console

Copy link

@AndriusA AndriusA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, wasn't aware that this is required

@bsclifton
Copy link
Member Author

OK great, this worked! 😄 Only reason CI shows as red for Jenkins is because test-install step failed, but this is known; captured with brave/brave-browser#9480

@bsclifton bsclifton merged commit c8fe06c into master May 6, 2020
@bsclifton bsclifton deleted the bsc-fix-macos-signing branch May 6, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS signing is broken in master
2 participants