-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolbar Tor profile icon #547
Conversation
A lot of overhead in this PR since we didn't seem to previously have anywhere to put Brave icons that weren't just replacements for existing Chromium icons. This creates such a project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@simonhong I think Guest Window uses a different flag on |
Added |
@bsclifton I had added the edit: ok this is wrong, those labels are only for brave-browser PRs. Thanks @bsclifton |
You got it 😄 Just to recap for others, for this repo, we just label the PR with the earliest (lowest version) version which the change was merged to |
Fix brave/brave-browser#1384
Added two sizes of vector icons since it's text and wanted to scale appropriately (the icon displays at different sizes for touch UI vs normal)
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist: