Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar Tor profile icon #547

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Toolbar Tor profile icon #547

merged 1 commit into from
Oct 2, 2018

Conversation

petemill
Copy link
Member

@petemill petemill commented Oct 2, 2018

Fix brave/brave-browser#1384

image

Added two sizes of vector icons since it's text and wanted to scale appropriately (the icon displays at different sizes for touch UI vs normal)

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • Open Tor Window
  • Observe that Avatar icon is 'Tor' icon

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@petemill
Copy link
Member Author

petemill commented Oct 2, 2018

A lot of overhead in this PR since we didn't seem to previously have anywhere to put Brave icons that weren't just replacements for existing Chromium icons. This creates such a project.

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhong
Copy link
Member

simonhong commented Oct 2, 2018

Just question, don't we use same theme for guest window?
Oops, I wrote to wrong PR

@petemill
Copy link
Member Author

petemill commented Oct 2, 2018

@simonhong I think Guest Window uses a different flag on profile since the icon is unchanged:
image

@petemill petemill merged commit 50b5fa3 into master Oct 2, 2018
petemill added a commit that referenced this pull request Oct 2, 2018
petemill added a commit that referenced this pull request Oct 2, 2018
@petemill
Copy link
Member Author

petemill commented Oct 2, 2018

0.56.x 2c4f4e2
0.55.x 513d352

@petemill petemill deleted the ui/tor-icon branch October 2, 2018 05:47
@bsclifton
Copy link
Member

Added merged/0.55.x label 😄

@petemill
Copy link
Member Author

petemill commented Oct 2, 2018

@bsclifton I had added the merged/X labels on to the issue at brave/brave-browser#1384 as I thought that's where they are meant to go since the brave-browser issues are separated from the branches and PR in this repo. Is that not right?

edit: ok this is wrong, those labels are only for brave-browser PRs. Thanks @bsclifton

@bsclifton
Copy link
Member

You got it 😄 Just to recap for others, for this repo, we just label the PR with the earliest (lowest version) version which the change was merged to

@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Tor" label on private windows with Tor
4 participants