-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move data from ledger_state into preferences #5647
Conversation
6d428b1
to
abdb64d
Compare
@@ -746,8 +744,6 @@ void RewardsServiceImpl::OnWalletInitialized(ledger::Result result) { | |||
ready_.Signal(); | |||
|
|||
if (result == ledger::Result::WALLET_CREATED) { | |||
SetRewardsMainEnabled(true); | |||
SetAutoContribute(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this fixes brave/brave-browser#9750
69c4697
to
7f205ab
Compare
f585505
to
288ab76
Compare
288ab76
to
5c77324
Compare
vendor/bat-native-ledger/src/bat/ledger/internal/api/api_parameters.cc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iOS looks good to me. will require a few changes on client side
5c77324
to
fb7a472
Compare
fb7a472
to
dc5a1a4
Compare
vendor/bat-native-ledger/src/bat/ledger/internal/api/api_parameters.h
Outdated
Show resolved
Hide resolved
vendor/bat-native-ledger/src/bat/ledger/internal/request/request_api.h
Outdated
Show resolved
Hide resolved
dc5a1a4
to
85d3d1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the chromium_src changes are fine, but I think we're missing most of the benefit of using prefs here by keeping async methods going back and forth to access every value
85d3d1c
to
d81bc87
Compare
CI passed on window, linux and ios. Restarting macos and android |
d81bc87
to
4fc7c73
Compare
4fc7c73
to
6f31ff2
Compare
6f31ff2
to
ec64dea
Compare
Resolves brave/brave-browser#9869
Resolves brave/brave-browser#9750
Resolves brave/brave-browser#7165
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
plan 1:
plan 2:
plan 3:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.