Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep ads state when disabling Brave Ads #5749

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Keep ads state when disabling Brave Ads #5749

merged 1 commit into from
Jun 5, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jun 5, 2020

Resolves brave/brave-browser#10097

Submitter Checklist:

Test Plan:

  • Confirm ads state is not reset when disabling Ads (see ads_service folder in user profile)

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@yachtcaptain23
Copy link
Contributor

Should we also get rid of the function declaration & OnResetAllState from ads_service_impl.cc and ads_service_impl.h?

@tmancey
Copy link
Collaborator Author

tmancey commented Jun 5, 2020

Should we also get rid of the function declaration & OnResetAllState from ads_service_impl.cc and ads_service_impl.h?

Not at this time as we will need shortly when we add reset rewards. Thanks

@tmancey tmancey added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Jun 5, 2020
@tmancey
Copy link
Collaborator Author

tmancey commented Jun 5, 2020

CI failed due to unrelated brave rewards browser test

@tmancey tmancey merged commit 5c542ac into master Jun 5, 2020
@tmancey tmancey deleted the issues/10097 branch June 5, 2020 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep ads state when disabling Brave Ads
3 participants