-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes crash in brave://settings/content/all. #5777
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
approved these changes
Jun 9, 2020
darkdh
reviewed
Jun 9, 2020
mkarolin
force-pushed
the
maxk-issue-10160
branch
from
June 9, 2020 14:46
a52054e
to
bb691b4
Compare
CI: only install test on Mac failed (known unrelated issue). |
Fixes brave/brave-browser#10160 Updated code to use a patch instead of the override for a function because the function is now called from the same file where it is defined.
mkarolin
force-pushed
the
maxk-issue-10160
branch
from
June 9, 2020 18:50
bb691b4
to
a2bc0f6
Compare
bsclifton
approved these changes
Jun 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great 👍
bridiver
approved these changes
Jun 9, 2020
mkarolin
added a commit
that referenced
this pull request
Jun 9, 2020
Fixes crash in brave://settings/content/all.
mkarolin
added a commit
that referenced
this pull request
Jun 9, 2020
Fixes crash in brave://settings/content/all.
This was referenced Jun 9, 2020
LGTM
No more crash. Verified test plan from brave/brave-browser#10160 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#10160
Updated code to use a patch instead of the override for a function
because the function is now called from the same file where it is
defined.
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.