Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate promotion last fetch on wallet restore #5786

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jun 9, 2020

Resolves brave/brave-browser#10181

Submitter Checklist:

Test Plan:

  • enable rewards
  • restore wallet that has ads grant pending
  • make sure that grant shows up after restore

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.12.x - Nightly milestone Jun 9, 2020
@NejcZdovc NejcZdovc requested a review from a team June 9, 2020 18:39
@NejcZdovc NejcZdovc self-assigned this Jun 9, 2020
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc merged commit e640eaa into master Jun 9, 2020
@NejcZdovc NejcZdovc deleted the invalidate-cache-on-restore branch June 9, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] Reset last promotion fetch on wallet restore
3 participants