Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update patches for 70.0.3538.54 #614

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Update patches for 70.0.3538.54 #614

merged 1 commit into from
Oct 11, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Oct 11, 2018

Fix brave/brave-browser#1522

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bbondy bbondy self-assigned this Oct 11, 2018
@bbondy bbondy requested a review from emerick October 11, 2018 20:16
emerick
emerick approved these changes Oct 11, 2018
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbondy bbondy merged commit 99bf16e into master Oct 11, 2018
bbondy added a commit that referenced this pull request Oct 11, 2018
@bbondy
Merge pull request #614 from brave/70.0.3538.54
b2a4035 
Update patches for 70.0.3538.54
bbondy added a commit that referenced this pull request Oct 11, 2018
@bbondy
Merge pull request #614 from brave/70.0.3538.54
4c87a3b 
Update patches for 70.0.3538.54
@bbondy
Copy link
Member Author

bbondy commented Oct 11, 2018

master: 99bf16e
0.56.x: b2a4035
0.55.x: 4c87a3b

@bsclifton bsclifton deleted the 70.0.3538.54 branch October 14, 2018 05:07
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
@snyk-bot snyk-bot mentioned this pull request Dec 19, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick emerick approved these changes

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
0.55.x - Release
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 70.0.3538.45 to 70.0.3538.54
2 participants
@bbondy @emerick