Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Debian alternative priority #6253

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Jul 29, 2020

Resolves fixes brave/brave-browser#11001

Submitter Checklist:

Test Plan:

  1. Install the brave-browser package on a Debian/Ubuntu machine.
  2. Run sudo update-alternatives --config x-www-browser

You should see something like:

  0            /usr/bin/brave-browser-stable      201       auto mode
* 1            /usr/bin/brave-browser-beta        151       manual mode
  2            /usr/bin/brave-browser-dev         1         manual mode
  3            /usr/bin/brave-browser-nightly     1         manual mode

Note: only the priority field is important here.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@fmarier fmarier added this to the 1.14.x - Nightly milestone Jul 29, 2020
@fmarier fmarier requested a review from bridiver July 29, 2020 19:41
@fmarier fmarier self-assigned this Jul 29, 2020
Copy link
Contributor

@kkuehlz kkuehlz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

@fmarier fmarier force-pushed the francois-bump-debian-alternative-priority-11001 branch from 4cf9d3a to c173c83 Compare July 29, 2020 20:31
@fmarier fmarier force-pushed the francois-bump-debian-alternative-priority-11001 branch from c173c83 to 207307d Compare July 29, 2020 22:51
@fmarier
Copy link
Member Author

fmarier commented Jul 30, 2020

@fmarier fmarier merged commit 685fa81 into master Jul 30, 2020
@fmarier fmarier deleted the francois-bump-debian-alternative-priority-11001 branch July 30, 2020 19:54
tmancey added a commit that referenced this pull request Aug 11, 2020
Automatically limit unwanted Brave Ads delivery
tmancey added a commit that referenced this pull request Sep 9, 2020
Fixes follow up to #6253: Automatically limit unwanted Brave Ads delivery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] Installing Brave on a Debian system with Chrome doesn't automatically set Brave as the default
3 participants