Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow FetchBalance to return an empty ledger::BalancePtr (uplift to 1.13.x) #6266

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Allow FetchBalance to return an empty ledger::BalancePtr (uplift to 1.13.x) #6266

merged 1 commit into from
Aug 5, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jul 30, 2020 •
edited by NejcZdovc
Loading

Uplift of #6251
Resolves brave/brave-browser#10983

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from NejcZdovc as a code owner July 30, 2020 13:25
@brave-builds brave-builds requested a review from a team July 30, 2020 13:25
@brave-builds brave-builds self-assigned this Jul 30, 2020
@brave-builds brave-builds added this to the 1.13.x - Beta milestone Jul 30, 2020
@NejcZdovc NejcZdovc removed their request for review July 31, 2020 04:59
@NejcZdovc
Copy link
Contributor

CI failed only on browser test RewardsBrowserTest.NotVerifiedWallet which is a known thing https://ci.brave.com/job/pr-brave-browser-pr6251_ksmith-balance-mojom-bug_1.13.x/2/execution/node/293/log/

kjozwiak
kjozwiak approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.13.x approved after deliberating with @brave/uplift-approvers. QA has also verified the PR on Nightly as per #6251 (comment).

@kjozwiak kjozwiak merged commit af0b737 into 1.13.x Aug 5, 2020
@kjozwiak kjozwiak deleted the pr6251_ksmith-balance-mojom-bug_1.13.x branch August 5, 2020 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
feature/rewards
Projects
None yet
Milestone
1.13.x - Release #1
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @NejcZdovc @kjozwiak @brave-browser-releases