Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix location bar layout isn't triggered by page action icon change #627

Merged
merged 1 commit into from
Oct 14, 2018

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Oct 13, 2018

When page action icon is changed, location bar layout should be done.
This is regression of recent change of
BraveLocationBarView::ChildPreferredSizeChanged(). It should call
base class base method call.

Fixes brave/brave-browser#1561

I missed this when I reviewed #587.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. Make omnibox unfocused
  2. Click omnibox
  3. Check findbar icon is overlapped or not

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

When page action icon is changed, location bar layout should be done.
This is regression of recent change of
BraveLocationBarView::ChildPreferredSizeChanged(). It should call
base class base method call.
@simonhong simonhong self-assigned this Oct 13, 2018
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, always call base class when possible since even if it has nothing currently, it could in the future.

@bbondy bbondy merged commit 6024245 into master Oct 14, 2018
@bbondy
Copy link
Member

bbondy commented Oct 14, 2018

tested and it works great btw.

bbondy added a commit that referenced this pull request Oct 14, 2018
Fix location bar layout isn't triggered by page action icon change
bbondy added a commit that referenced this pull request Oct 14, 2018
Fix location bar layout isn't triggered by page action icon change
@bbondy
Copy link
Member

bbondy commented Oct 14, 2018

master: 6024245
0.56.x: 9b3e830
0.55.x: 01a712d

@bsclifton bsclifton deleted the location_bar_layout branch October 14, 2018 05:07
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
@bbondy bbondy removed the 0.55.x label Jan 14, 2019
fmarier pushed a commit that referenced this pull request Oct 29, 2019
Adds ignore rules for CLion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find icon on URL bar overlaps on Shields
2 participants