Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switch to QA Preferences to enable vlog on Android #6343

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Aug 5, 2020

Add switch to QA Preferences to enable vlog messages for rewards and ads for QA team

Resolves brave/brave-browser#11088

Submitter Checklist:

Test Plan:

  1. Connect phone with USB cable to computer, launch Android Device Monitor or Android Studio, enable filtering for Brave browser
  2. Install apk
  3. Go to kebab => Settings => Developer options => QA Preferences
  4. Enable vlog for rewards should be in position off
  5. Switch it to position on, restart when prompted
  6. Find these messages in log
[VERBOSE1:ads_service_impl.cc(1308)] Migrating ads preferences
[VERBOSE2:ads_service_impl.cc(1334)] Ads preferences are up to date on version 7
  1. Go to kebab => Settings => Developer options => QA Preferences
  2. Switch Enable vlog for rewards to position off, restart
  3. You should not find messages from pt6 in log

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@AlexeyBarabash
Copy link
Contributor Author

Updated command line option after talk with @tmancey and @NejcZdovc

Skip all CI except Android, as all CI has been succeeded.

@AlexeyBarabash AlexeyBarabash added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 enhancement labels Aug 6, 2020
@AlexeyBarabash
Copy link
Contributor Author

Fixed lint error

@AlexeyBarabash
Copy link
Contributor Author

CI succeeded, but I have still cannot verify these option actually makes the vlog output expected, can't be merged yet.

@AlexeyBarabash AlexeyBarabash marked this pull request as draft August 6, 2020 15:18
@AlexeyBarabash AlexeyBarabash force-pushed the android_vlog_rewards branch 2 times, most recently from f9bfe40 to 0260b60 Compare August 8, 2020 20:18
@AlexeyBarabash AlexeyBarabash marked this pull request as ready for review August 8, 2020 20:18
@AlexeyBarabash AlexeyBarabash removed CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Aug 9, 2020
@AlexeyBarabash
Copy link
Contributor Author

CI failed on Windows for s3-upload phase

13:13:48  powershell.exe : upload failed: .\ to s3://****/brave-browser-build-pr/android_vlog_rewards/\ufffd\ufffde [Errno 2] No such file or directory: 
13:13:48  'C:\\ards\\src\\out\\Release\\'
13:13:48  At C:\ards@tmp\durable-fca1ffef\powershellWrapper.ps1:3 char:1
13:13:48  + & powershell -NoProfile -NonInteractive -ExecutionPolicy Bypass -Comm ...
13:13:48  + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
13:13:48      + CategoryInfo          : NotSpecified: (upload failed: ...out\\Release\\':String) [], RemoteException
13:13:48      + FullyQualifiedErrorId : NativeCommandError
13:13:48   
13:13:48  upload failed: .\ to s3://****/brave-browser-build-pr/android_vlog_rewards/\ufffd\ufffde [Errno 2] No such file or directory: 'C:\\ards\\src\\out\\Release\\'
13:13:48  
13:13:49  upload failed: dist\ to s3://****/brave-browser-build-pr/android_vlog_rewards/\ufffd\ufffde [Errno 2] No such file or directory: 'C:\\ards\\src\\out\\Release\\dist\\'
13:13:49  

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexeyBarabash AlexeyBarabash marked this pull request as draft August 10, 2020 17:18
@AlexeyBarabash
Copy link
Contributor Author

Converted to draft because received request and explanation from @bridiver how to redo this without patches

@AlexeyBarabash
Copy link
Contributor Author

Looks good to me @SergeyZhukovsky

@SergeyZhukovsky SergeyZhukovsky marked this pull request as ready for review August 14, 2020 19:40
@SergeyZhukovsky SergeyZhukovsky added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Aug 14, 2020
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SergeyZhukovsky SergeyZhukovsky merged commit 07dcae5 into master Aug 17, 2020
@SergeyZhukovsky SergeyZhukovsky deleted the android_vlog_rewards branch August 17, 2020 13:45
@AlexeyBarabash AlexeyBarabash added this to the 1.14.x - Nightly milestone Aug 17, 2020
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.15.2 x64 nightly build

  • Verified enabling vlog option from QA preferences logs rewards output in Android studio
  • Verified disabling vlog option from QA preferences doesn't show any logs output in Android Studio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Add developer option to enable rewards vlog output
6 participants