-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add switch to QA Preferences to enable vlog on Android #6343
Conversation
8f99ea6
to
8b924d4
Compare
Updated command line option after talk with @tmancey and @NejcZdovc Skip all CI except Android, as all CI has been succeeded. |
8b924d4
to
9e9ba29
Compare
Fixed lint error |
CI succeeded, but I have still cannot verify these option actually makes the vlog output expected, can't be merged yet. |
f9bfe40
to
0260b60
Compare
0260b60
to
1481158
Compare
CI failed on Windows for s3-upload phase
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Converted to draft because received request and explanation from @bridiver how to redo this without patches |
1481158
to
68acb71
Compare
68acb71
to
a535590
Compare
Looks good to me @SergeyZhukovsky |
a535590
to
5bcfd89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Verification passed on OnePlus 6T with Android 10 running 1.15.2 x64 nightly build
|
Add switch to QA Preferences to enable vlog messages for rewards and ads for QA team
Resolves brave/brave-browser#11088
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Enable vlog for rewards
should be in position offEnable vlog for rewards
to position off, restartReviewer Checklist:
After-merge Checklist:
changes has landed on.